Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move packaging to requirements.txt to fix check_install #2273

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Move packaging to requirements.txt to fix check_install #2273

merged 3 commits into from
Jan 18, 2023

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jan 18, 2023 •
edited
Loading

Closes #2272

Code Changes

  • Move packaging to requirements.txt

Steps to Confirm

  • pip install .
  • pip list | grep packaging returns the correct version

Pre-Merge Checklist

Description Of Changes

Found in #2263 and #2226

@SteveDMurphy SteveDMurphy mentioned this pull request Jan 18, 2023
Closed
@sanders41
Copy link
Contributor

I did the pip install . and verified the package is installed and the correct version, but am still getting the failure with nox -s check_install. Is there another step I need?

@SteveDMurphy
Copy link
Contributor Author

I did the pip install . and verified the package is installed and the correct version, but am still getting the failure with nox -s check_install. Is there another step I need?

Hmm, that did it for me and the ci check seems to pass now 🤔 I did also trash my virtual environment to try and recreate how the test is run. If not that, maybe something with a specific Python version? I'm on 3.9.15

@sanders41
Copy link
Contributor

I'm 3.10.9. Trying to recreate my virtual environment now to see what that does.

sanders41
sanders41 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My virtual environment is being slow about reinstalling after re-creating. I'm going to go ahead an approve here since it is passing CI with this change, and gets PRs unblocked.

@sanders41
Copy link
Contributor

Virtual environment finished and it still failed, but I would still rather merge this and get CI going again.

@SteveDMurphy
Copy link
Contributor Author

Virtual environment finished and it still failed, but I would still rather merge this and get CI going again.

Hmm, interesting for sure - thanks for the review and taking the time to look at it!

@SteveDMurphy SteveDMurphy marked this pull request as ready for review January 18, 2023 23:00
@SteveDMurphy SteveDMurphy merged commit 3c308f1 into main Jan 18, 2023
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-2272-check-install-bug branch January 18, 2023 23:02
@sanders41 sanders41 mentioned this pull request Jan 20, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 approved these changes

@allisonking allisonking Awaiting requested review from allisonking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nox -s check_install failing on main
2 participants
@SteveDMurphy @sanders41